Skip to content

fix(navigation): keep Downloads visible from launch - #249

Open
blurbery wants to merge 1 commit into
Silo-Server:mainfrom
blurbery:contrib/persistent-downloads-tab
Open

fix(navigation): keep Downloads visible from launch#249
blurbery wants to merge 1 commit into
Silo-Server:mainfrom
blurbery:contrib/persistent-downloads-tab

Conversation

@blurbery

@blurbery blurbery commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

What I changed

I noticed the Downloads tab was missing when the Android app first opened, then suddenly appeared after download records or local storage finished loading. That made the whole bottom bar reflow after launch.

I changed Downloads into a fixed mobile navigation destination from the first rendered frame. The Downloads screen still owns its empty and unavailable states, while capability and record hydration no longer decide whether the navigation item exists.

This also removes the startup record/local-byte scan that was only being used to decide tab visibility. Offline launch routing is unchanged.

Testing

I designed and tested this behavior to make sure the bottom bar stays stable from launch.

  • Android navigation unit tests pass
  • Verified Downloads is present in the fixed tab list before records load
  • Verified the existing offline Downloads start logic remains covered

AI disclosure

I designed the navigation behavior and tested the result. I used AI assistance to help implement the change, simplify the old visibility path, and add regression coverage.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 24 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e670e08d-097a-4756-aab4-26dbe2da6458

📥 Commits

Reviewing files that changed from the base of the PR and between a071dea and 7037fff.

📒 Files selected for processing (5)
  • androidApp/src/androidMain/kotlin/org/siloserver/silo/android/ui/navigation/MobileDownloadVisibility.kt
  • androidApp/src/androidMain/kotlin/org/siloserver/silo/android/ui/navigation/MobileMediaTabs.kt
  • androidApp/src/androidMain/kotlin/org/siloserver/silo/android/ui/screens/MainScreen.kt
  • androidApp/src/androidUnitTest/kotlin/org/siloserver/silo/android/ui/navigation/MobileDownloadVisibilityTest.kt
  • androidApp/src/androidUnitTest/kotlin/org/siloserver/silo/android/ui/navigation/MobileMediaTabsTest.kt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@blurbery
blurbery marked this pull request as draft August 26, 2026 08:20
@blurbery
blurbery marked this pull request as ready for review August 26, 2026 09:24
@blurbery

blurbery commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 24 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@blurbery